Skip to content

[cxx-interop] Add std::set initializer that takes a Swift Sequence #65087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

[cxx-interop] Add std::set initializer that takes a Swift Sequence #65087

merged 1 commit into from
Jun 13, 2023

Conversation

egorzhdan
Copy link
Contributor

This got unblocked by #64897.

rdar://107909624

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Apr 11, 2023
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners April 11, 2023 23:54
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please test

hyp
hyp approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, now we just need an insert as well :)

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-set-init branch from 2b96c27 to bac1045 Compare April 12, 2023 14:17
@egorzhdan
Copy link
Contributor Author

Nice, now we just need an insert as well :)

Oh good point! We'll need to decide on the return type though, so I'd prefer to add func insert in a separate PR.

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-set-init branch from bac1045 to cad0475 Compare April 18, 2023 14:51
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan mentioned this pull request May 26, 2023
Merged
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-set-init branch from cad0475 to c52dd01 Compare June 2, 2023 21:19
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan mentioned this pull request Jun 5, 2023
Merged
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-set-init branch from c52dd01 to 16add36 Compare June 8, 2023 22:56
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-set-init branch from 16add36 to ff703ca Compare June 9, 2023 11:29
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-set-init branch from ff703ca to 7a49105 Compare June 9, 2023 14:02
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-set-init branch from 7a49105 to dd7e177 Compare June 13, 2023 13:51
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit 74192c0 into main Jun 13, 2023
@egorzhdan egorzhdan deleted the egorzhdan/cxx-set-init branch June 13, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyp hyp hyp approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @hyp